netdev - Re: [PATCH] [net] update xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aeb75e09bec3e4459c5ade3c1f1149841ecae82c.camel@redhat.com>
Date:   Tue, 04 Apr 2023 11:42:14 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     nick black <dankamongmen@...il.com>, netdev@...r.kernel.org
Cc:     Magnus Karlsson <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>
Subject: Re: [PATCH] [net] update xdp_statistics in docs

On Tue, 2023-04-04 at 11:35 +0200, Paolo Abeni wrote:
> On Sun, 2023-04-02 at 04:41 -0400, nick black wrote:
> > Add the three fields from xdp_statistics that were
> > missing in the AF_XDP documentation.
> > 
> > Signed-off-by: nick black <dankamongmen@...il.com>
> 
> I think this kind of changes are best suited for net-next, please set
> the target tree accordingly in next submissions.
> 
> > ---
> >  Documentation/networking/af_xdp.rst | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git Documentation/networking/af_xdp.rst Documentation/networking/af_xdp.rst
> > index 247c6c4127e9..a968de7e902c 100644
> > --- Documentation/networking/af_xdp.rst
> > +++ Documentation/networking/af_xdp.rst
> 
> There is something strange in your setup, the above should be:
> 
> --- a/Documentation/networking/af_xdp.rst
> +++ b/Documentation/networking/af_xdp.rst
> 
> The format you used confuses my scripts. I handled this one manually,
> but please update your setup to stick to the standard layout.

I almost forgot: you should include into the subject a tag identifying
the relevant subsystem/networking area. In this case, a proper subject
could be:

net: doc: update xdp_statistics in docs

Given all the above I think is better if you re-submit addressing my
comments. You can retain Magnus's ack.

Thanks!

Paolo