netdev - Re: [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 10:00:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        Dmitry Safonov <dima@...sta.com>,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        Dan Carpenter <error27@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri05@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>,
        Salam Noureddine <noureddine@...sta.com>
Subject: Re: [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk

Hi Dmitry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 7e364e56293bb98cae1b55fd835f5991c4e96e7d]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020
base:   7e364e56293bb98cae1b55fd835f5991c4e96e7d
patch link:    https://lore.kernel.org/r/20230403213420.1576559-10-dima%40arista.com
patch subject: [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230404/202304040904.0iYIgRHd-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6dd2eb18d51db7f4e1bfac2de38f7a5c2363ef0e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020
        git checkout 6dd2eb18d51db7f4e1bfac2de38f7a5c2363ef0e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/ipv6/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304040904.0iYIgRHd-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv6/tcp_ipv6.c: In function 'tcp_v6_timewait_ack':
>> net/ipv6/tcp_ipv6.c:1214:36: warning: variable 'rnext_key' set but not used [-Wunused-but-set-variable]
    1214 |                 struct tcp_ao_key *rnext_key;
         |                                    ^~~~~~~~~


vim +/rnext_key +1214 net/ipv6/tcp_ipv6.c

  1190	
  1191	static void tcp_v6_timewait_ack(struct sock *sk, struct sk_buff *skb)
  1192	{
  1193		struct inet_timewait_sock *tw = inet_twsk(sk);
  1194		struct tcp_timewait_sock *tcptw = tcp_twsk(sk);
  1195		struct tcp_ao_key *ao_key = NULL;
  1196		u8 *traffic_key = NULL;
  1197		u8 rcv_next = 0;
  1198		u32 ao_sne = 0;
  1199	#ifdef CONFIG_TCP_AO
  1200		struct tcp_ao_info *ao_info;
  1201	
  1202		/* FIXME: the segment to-be-acked is not verified yet */
  1203		ao_info = rcu_dereference(tcptw->ao_info);
  1204		if (ao_info) {
  1205			const struct tcp_ao_hdr *aoh;
  1206	
  1207			/* Invalid TCP option size or twice included auth */
  1208			if (tcp_parse_auth_options(tcp_hdr(skb), NULL, &aoh))
  1209				goto out;
  1210			if (aoh)
  1211				ao_key = tcp_ao_established_key(ao_info, aoh->rnext_keyid, -1);
  1212		}
  1213		if (ao_key) {
> 1214			struct tcp_ao_key *rnext_key;
  1215	
  1216			traffic_key = snd_other_key(ao_key);
  1217			/* rcv_next switches to our rcv_next */
  1218			rnext_key = READ_ONCE(ao_info->rnext_key);
  1219			rcv_next = ao_info->rnext_key->rcvid;
  1220			ao_sne = tcp_ao_compute_sne(ao_info->snd_sne,
  1221						    ao_info->snd_sne_seq,
  1222						    tcptw->tw_snd_nxt);
  1223		}
  1224	#endif
  1225	
  1226		tcp_v6_send_ack(sk, skb, tcptw->tw_snd_nxt, tcptw->tw_rcv_nxt,
  1227				tcptw->tw_rcv_wnd >> tw->tw_rcv_wscale,
  1228				tcp_time_stamp_raw() + tcptw->tw_ts_offset,
  1229				tcptw->tw_ts_recent, tw->tw_bound_dev_if, tcp_twsk_md5_key(tcptw),
  1230				tw->tw_tclass, cpu_to_be32(tw->tw_flowlabel), tw->tw_priority,
  1231				tw->tw_txhash, ao_key, traffic_key, rcv_next, ao_sne);
  1232	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests