netdev - Re: [PATCH net] selftests: net: rps_default_mask.sh: delete veth link specifically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 04 Apr 2023 12:40:06 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net
Subject: Re: [PATCH net] selftests: net: rps_default_mask.sh: delete veth
 link specifically

On Tue, 2023-04-04 at 15:24 +0800, Hangbin Liu wrote:
> When deleting the netns and recreating a new one while re-adding the
> veth interface, there is a small window of time during which the old
> veth interface has not yet been removed. This can cause the new addition
> to fail. To resolve this issue, we can either wait for a short while to
> ensure that the old veth interface is deleted, or we can specifically
> remove the veth interface.
> 
> Before this patch:
>   # ./rps_default_mask.sh
>   empty rps_default_mask                                      [ ok ]
>   changing rps_default_mask dont affect existing devices      [ ok ]
>   changing rps_default_mask dont affect existing netns        [ ok ]
>   changing rps_default_mask affect newly created devices      [ ok ]
>   changing rps_default_mask don't affect newly child netns[II][ ok ]
>   rps_default_mask is 0 by default in child netns             [ ok ]
>   RTNETLINK answers: File exists
>   changing rps_default_mask in child ns don't affect the main one[ ok ]
>   cat: /sys/class/net/vethC11an1/queues/rx-0/rps_cpus: No such file or directory
>   changing rps_default_mask in child ns affects new childns devices./rps_default_mask.sh: line 36: [: -eq: unary operator expected
>   [fail] expected 1 found
>   changing rps_default_mask in child ns don't affect existing devices[ ok ]
> 
> After this patch:
>   # ./rps_default_mask.sh
>   empty rps_default_mask                                      [ ok ]
>   changing rps_default_mask dont affect existing devices      [ ok ]
>   changing rps_default_mask dont affect existing netns        [ ok ]
>   changing rps_default_mask affect newly created devices      [ ok ]
>   changing rps_default_mask don't affect newly child netns[II][ ok ]
>   rps_default_mask is 0 by default in child netns             [ ok ]
>   changing rps_default_mask in child ns don't affect the main one[ ok ]
>   changing rps_default_mask in child ns affects new childns devices[ ok ]
>   changing rps_default_mask in child ns don't affect existing devices[ ok ]
> 
> Fixes: 3a7d84eae03b ("self-tests: more rps self tests")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/rps_default_mask.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/rps_default_mask.sh b/tools/testing/selftests/net/rps_default_mask.sh
> index 0fd0d2db3abc..a26c5624429f 100755
> --- a/tools/testing/selftests/net/rps_default_mask.sh
> +++ b/tools/testing/selftests/net/rps_default_mask.sh
> @@ -60,6 +60,7 @@ ip link set dev $VETH up
>  ip -n $NETNS link set dev $VETH up
>  chk_rps "changing rps_default_mask affect newly created devices" "" $VETH 3
>  chk_rps "changing rps_default_mask don't affect newly child netns[II]" $NETNS $VETH 0
> +ip link del dev $VETH
>  ip netns del $NETNS
>  
>  setup

LGTM, thanks!

Acked-by: Paolo Abeni <pabeni@...hat.com>