netdev - Re: [RFC PATCH net-next 5/6] net: ethtool: add a mutex protecting RSS contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9536914b-0254-23e4-de6d-a936a50129b0@gmail.com>
Date:   Tue, 4 Apr 2023 13:32:04 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, edward.cree@....com
Cc:     linux-net-drivers@....com, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        habetsm.xilinx@...il.com, sudheer.mogilappagari@...el.com
Subject: Re: [RFC PATCH net-next 5/6] net: ethtool: add a mutex protecting RSS
 contexts

On 03/04/2023 23:03, Jakub Kicinski wrote:
> On Mon, 3 Apr 2023 17:33:02 +0100 edward.cree@....com wrote:
>>  	u32			rss_ctx_max_id;
>>  	struct idr		rss_ctx;
>> +	struct mutex		rss_lock;
> 
> Argh, the mutex doubles the size of the state, and most drivers don't
> implement this feature.  My thinking was to add a "ethtool state"> pointer to net_device which will be allocated by ethtool on demand
> and can hold all ethtool related state.

Would any other existing net_device fields go in this struct, or is
 it just the RSS stuff so far?