netdev - Re: [PATCH net-next v1 3/7] net: dsa: microchip: ksz8: Make ksz8_r_sta_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230404160044.GC4044@pengutronix.de>
Date:   Tue, 4 Apr 2023 18:00:44 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Arun.Ramadoss@...rochip.com
Cc:     olteanv@...il.com, andrew@...n.ch, f.fainelli@...il.com,
        kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com,
        Woojung.Huh@...rochip.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, kernel@...gutronix.de
Subject: Re: [PATCH net-next v1 3/7] net: dsa: microchip: ksz8: Make
 ksz8_r_sta_mac_table() static

On Tue, Apr 04, 2023 at 03:11:02PM +0000, Arun.Ramadoss@...rochip.com wrote:
> Hi Oleksij,
> On Tue, 2023-04-04 at 12:18 +0200, Oleksij Rempel wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> > 
> > As ksz8_r_sta_mac_table() is only used within ksz8795.c, there is no
> > need
> > to export it. Make the function static for better encapsulation.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  drivers/net/dsa/microchip/ksz8.h    | 2 --
> >  drivers/net/dsa/microchip/ksz8795.c | 4 ++--
> >  2 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/dsa/microchip/ksz8.h
> > b/drivers/net/dsa/microchip/ksz8.h
> > index ad2c3a72a576..d87f8ebc6323 100644
> > --- a/drivers/net/dsa/microchip/ksz8.h
> > +++ b/drivers/net/dsa/microchip/ksz8.h
> > @@ -21,8 +21,6 @@ int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16
> > reg, u16 *val);
> >  int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val);
> >  int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8
> > *mac_addr,
> >                          u8 *fid, u8 *src_port, u8 *timestamp, u16
> > *entries);
> > -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr,
> > -                        struct alu_struct *alu);
> 
> 
> ksz8_r_dyn_mac_table() also not used outside KSZ8795.h. It can
> also be made static

:) Ack, i have pending series of patch for dyn MAC table.

> Acked-by: Arun Ramadoss <arun.ramadoss@...rochip.com>



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |