lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230404164429.GL4514@unreal> Date: Tue, 4 Apr 2023 19:44:29 +0300 From: Leon Romanovsky <leon@...nel.org> To: Yang Li <yang.lee@...ux.alibaba.com> Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, saeedm@...dia.com, netdev@...r.kernel.org, simon.horman@...igine.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com> Subject: Re: [PATCH net-next v3] net/mlx5e: Remove NULL check before dev_{put, hold} On Tue, Apr 04, 2023 at 03:29:32PM +0800, Yang Li wrote: > ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:35:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. > ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:72:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed. > ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:80:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. > ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:35:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. > ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:734:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. > ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:769:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. > ./drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4667 > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com> > --- > > change in v3: > --According to Leon's suggestion, do this cleanup for whole driver. > > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 9 +++------ > .../net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c | 10 +++------- > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +-- > 3 files changed, 7 insertions(+), 15 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists