netdev - Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCuLTjZjg7pZqO0X@Laptop-X1>
Date:   Tue, 4 Apr 2023 10:28:30 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jonathan Toppins <jtoppins@...hat.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, Liang Li <liali@...hat.com>
Subject: Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests

On Fri, Mar 31, 2023 at 10:31:47AM +0800, Hangbin Liu wrote:
> > > +++ b/tools/testing/selftests/drivers/net/bonding/bond_lib.sh
> > 
> > I like this idea, we might want to separate network topology from library
> > code however. That way a given test case can just include a predefined
> 
> Would you like to help explain more clear? Separate network topology to where?


Hi Jon, would you please help explain this part?

Thanks
Hangbin

> 
> > topology. A quick review of the test cases show a 2 node setup is the most
> > common across all test cases.
> 
> Liang suggested that with 2 clients we can test xmit_hash_policy. In
> client_create() I only create 1 client for current testing. We can add more
> clients in future.
> 
> Thanks
> Hangbin