netdev - Re: [PATCH 2/2] net: thunderbolt: Fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 21:25:14 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: thunderbolt: Fix typo in comment

On Tue, Apr 04, 2023 at 08:36:36AM +0300, Mika Westerberg wrote:
> Should be UDP not UPD. No functional changes.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Looks good,

Reviewed-by: Simon Horman <simon.horman@...igine.com>

codespell tells me you also may want to consider:

$ codespell drivers/net/thunderbolt/main.c
drivers/net/thunderbolt/main.c:151: blongs ==> belongs

> ---
>  drivers/net/thunderbolt/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c
> index 6a43ced74881..0ce501e34f3f 100644
> --- a/drivers/net/thunderbolt/main.c
> +++ b/drivers/net/thunderbolt/main.c
> @@ -1030,7 +1030,7 @@ static bool tbnet_xmit_csum_and_map(struct tbnet *net, struct sk_buff *skb,
>  	/* Data points on the beginning of packet.
>  	 * Check is the checksum absolute place in the packet.
>  	 * ipcso will update IP checksum.
> -	 * tucso will update TCP/UPD checksum.
> +	 * tucso will update TCP/UDP checksum.
>  	 */
>  	if (protocol == htons(ETH_P_IP)) {
>  		__sum16 *ipcso = dest + ((void *)&(ip_hdr(skb)->check) - data);
> -- 
> 2.39.2
>