netdev - Re: [PATCH bpf] selftests: xsk: Disable IPv6 on VETH1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzYO0fsyUsLHe0t9yuw+BWaBJrvGBgBw213BpLNif=SOTw@mail.gmail.com>
Date:   Tue, 4 Apr 2023 16:11:15 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Kal Conley <kal.conley@...tris.com>
Cc:     Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
        Weqaar Janjua <weqaar.janjua@...il.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf] selftests: xsk: Disable IPv6 on VETH1

On Mon, Apr 3, 2023 at 5:05 AM Kal Conley <kal.conley@...tris.com> wrote:
>
> This change fixes flakiness in the BIDIRECTIONAL test:
>
>     # [is_pkt_valid] expected length [60], got length [90]
>     not ok 1 FAIL: SKB BUSY-POLL BIDIRECTIONAL
>
> When IPv6 is enabled, the interface will periodically send MLDv1 and
> MLDv2 packets. These packets can cause the BIDIRECTIONAL test to fail
> since it uses VETH0 for RX.
>
> For other tests, this was not a problem since they only receive on VETH1
> and IPv6 was already disabled on VETH0.
>
> Fixes: a89052572ebb ("selftests/bpf: Xsk selftests framework")
> Signed-off-by: Kal Conley <kal.conley@...tris.com>
> ---

Can you please resubmit with [PATCH bpf-next] tag, so BPF CI can test
it against the bpf-next tree. Thanks.

>  tools/testing/selftests/bpf/test_xsk.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
> index b077cf58f825..377fb157a57c 100755
> --- a/tools/testing/selftests/bpf/test_xsk.sh
> +++ b/tools/testing/selftests/bpf/test_xsk.sh
> @@ -116,6 +116,7 @@ setup_vethPairs() {
>         ip link add ${VETH0} numtxqueues 4 numrxqueues 4 type veth peer name ${VETH1} numtxqueues 4 numrxqueues 4
>         if [ -f /proc/net/if_inet6 ]; then
>                 echo 1 > /proc/sys/net/ipv6/conf/${VETH0}/disable_ipv6
> +               echo 1 > /proc/sys/net/ipv6/conf/${VETH1}/disable_ipv6
>         fi
>         if [[ $verbose -eq 1 ]]; then
>                 echo "setting up ${VETH1}"
> --
> 2.39.2
>