lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <168066061761.16096.17994837774956890281.git-patchwork-notify@kernel.org> Date: Wed, 05 Apr 2023 02:10:17 +0000 From: patchwork-bot+netdevbpf@...nel.org To: Simon Horman <horms@...nel.org> Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, mani@...nel.org, rostedt@...dmis.org, mhiramat@...nel.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: qrtr: correct types of trace event parameters Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@...nel.org>: On Mon, 03 Apr 2023 17:43:16 +0200 you wrote: > The arguments passed to the trace events are of type unsigned int, > however the signature of the events used __le32 parameters. > > I may be missing the point here, but sparse flagged this and it > does seem incorrect to me. > > net/qrtr/ns.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/qrtr.h): > ./include/trace/events/qrtr.h:11:1: warning: cast to restricted __le32 > ./include/trace/events/qrtr.h:11:1: warning: restricted __le32 degrades to integer > ./include/trace/events/qrtr.h:11:1: warning: restricted __le32 degrades to integer > ... (a lot more similar warnings) > net/qrtr/ns.c:115:47: expected restricted __le32 [usertype] service > net/qrtr/ns.c:115:47: got unsigned int service > net/qrtr/ns.c:115:61: warning: incorrect type in argument 2 (different base types) > ... (a lot more similar warnings) > > [...] Here is the summary with links: - [net-next] net: qrtr: correct types of trace event parameters https://git.kernel.org/netdev/net-next/c/054fbf7ff814 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists