lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZC2rDr0lE6p9VsdQ@shell.armlinux.org.uk> Date: Wed, 5 Apr 2023 18:08:30 +0100 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Guenter Roeck <linux@...ck-us.net> Cc: Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Ong Boon Leong <boon.leong.ong@...el.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Looi Hong Aun <hong.aun.looi@...el.com>, Voon Weifeng <weifeng.voon@...el.com>, Lai Peter Jun Ann <peter.jun.ann.lai@...el.com> Subject: Re: [PATCH net v3 2/3] net: stmmac: check if MAC needs to attach to a PHY On Wed, Apr 05, 2023 at 10:02:16AM -0700, Guenter Roeck wrote: > Hi, > > On Fri, Mar 24, 2023 at 04:16:55PM +0800, Michael Sit Wei Hong wrote: > > After the introduction of the fixed-link support, the MAC driver > > no longer attempt to scan for a PHY to attach to. This causes the > > non fixed-link setups to stop working. > > > > Using the phylink_expects_phy() to check and determine if the MAC > > should expect and attach a PHY. > > > > Fixes: ab21cf920928 ("net: stmmac: make mdio register skips PHY scanning for fixed-link") > > Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@...el.com> > > Signed-off-by: Lai Peter Jun Ann <peter.jun.ann.lai@...el.com> > > With this patch in linux-next, the orangepi-pc qemu emulation fails to > bring up the Ethernet interface. The following error is seen. > > [ 12.482401] dwmac-sun8i 1c30000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0 > [ 12.487789] dwmac-sun8i 1c30000.ethernet eth0: PHY [mdio_mux-0.1:01] driver [Generic PHY] (irq=POLL) > [ 12.488177] dwmac-sun8i 1c30000.ethernet eth0: no phy found > [ 12.488295] dwmac-sun8i 1c30000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19) > > Reverting this patch fixes the problem. Please see 20230405093945.3549491-1-michael.wei.hong.sit@...el.com for the fix. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists