netdev - Re: [PATCH net-next RFC v2] Add NDOs for hardware timestamp get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP5jrPGwyyLMTNpriOA71sMH4fRAefV5Bbe=X=2v_ML9JJdwdw@mail.gmail.com>
Date:   Wed, 5 Apr 2023 00:42:28 -0600
From:   Max Georgiev <glipus@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        kory.maincent@...tlin.com, netdev@...r.kernel.org,
        maxime.chevallier@...tlin.com,
        Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        Richard Cochran <richardcochran@...il.com>,
        Gerhard Engleder <gerhard@...leder-embedded.com>
Subject: Re: [PATCH net-next RFC v2] Add NDOs for hardware timestamp get/set

Thank you for the comments!

I've sent out v3 of the RFC stack to let the comment flow, and to
potentially unblock Köry.
I've added patches to insert ifr pointer into struct
kernel_hwtstamp_config as Jakub suggested, but no code is relying on
this new field yet.
I also added a patch which is supposed to fix the VLAN code path. I
can implement ndo_hwtstamp_get/set in VLAN as well - please comment if
it would be a good idea.
I haven't fixed bond_eth_ioctl() yet - will add it in the next
version. More driver conversion patches are planned as was discussed.

On Tue, Apr 4, 2023 at 5:25 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 4 Apr 2023 15:30:15 +0300 Vladimir Oltean wrote:
> > On Mon, Apr 03, 2023 at 09:42:09AM -0600, Max Georgiev wrote:
> > > The conversions are going to be easy (that was the point of adding these NDO
> > > functions). But there is still a problem of validating these
> > > conversions with testing.
> > > Unfortunately I don't have an e1000 card available to validate this conversion.
> > > I'll let you and Jakub decide what will be the best strategy here.
> >
> > If you can convert one of the drivers under drivers/net/ethernet/freescale/
> > with the exception of fec_main.c, or net/dsa/ + drivers/net/dsa/sja1105/
> > or drivers/net/dsa/mv88e6xxx/, then I can help with testing.
> >
> > By the way, after inspecting the kernel code a bit more, it also looks
> > like we need to convert vlan_dev_ioctl() and bond_eth_ioctl() to
> > something compatible with lower interfaces using the new and the old
> > API, before converting any driver. Otherwise we'll need to do that later
> > anyway, when regression reports start coming in. So these 2 are
> > non-optional whatever you do.
>
> Alternatively we could have them call back to the core helper
> to descend to a lower device. Stuff ifr into struct
> kernel_hwtstamp_config for now in case lower is not converted.