netdev - Re: [PATCH net v5 2/3] net: stmmac: check if MAC needs to attach to a PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f32d74cf-22e6-7c03-c9c9-a51eb5d10db6@synopsys.com>
Date:   Wed, 5 Apr 2023 09:06:23 +0000
From:   Shahab Vahedi <Shahab.Vahedi@...opsys.com>
To:     Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>
CC:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Vineet Gupta <vgupta@...nel.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "boon.leong.ong@...el.com" <boon.leong.ong@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "hong.aun.looi@...el.com" <hong.aun.looi@...el.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "peter.jun.ann.lai@...el.com" <peter.jun.ann.lai@...el.com>,
        "weifeng.voon@...el.com" <weifeng.voon@...el.com>
Subject: Re: [PATCH net v5 2/3] net: stmmac: check if MAC needs to attach to a
 PHY

Fixing the CC header. Apologies for the inconvenience.

------

Same happens on ARC HSDK [1]:

# dmesg | grep stmmaceth
  stmmaceth f0008000.ethernet: use coherent DMA ops
  stmmaceth f0008000.ethernet: IRQ eth_wake_irq not found
  stmmaceth f0008000.ethernet: IRQ eth_lpi not found
  stmmaceth f0008000.ethernet: PTP uses main clock
  stmmaceth f0008000.ethernet: User ID: 0x10, Synopsys ID: 0x37
  stmmaceth f0008000.ethernet:    DWMAC1000
  stmmaceth f0008000.ethernet: DMA HW capability register supported
  stmmaceth f0008000.ethernet: RX Checksum Offload Engine supported
  stmmaceth f0008000.ethernet: COE Type 2
  stmmaceth f0008000.ethernet: TX Checksum insertion supported
  stmmaceth f0008000.ethernet: Normal descriptors
  stmmaceth f0008000.ethernet: Ring mode enabled
  stmmaceth f0008000.ethernet: Enable RX Mitigation via HW Watchdog Timer
  stmmaceth f0008000.ethernet: device MAC address 7e:14:df:5f:b8:78
  stmmaceth f0008000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
  stmmaceth f0008000.ethernet eth0: PHY [stmmac-0:00] driver [Micrel KSZ9031 Gigabit PHY] (irq=POLL)
  stmmaceth f0008000.ethernet eth0: no phy found
  stmmaceth f0008000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)

After reverting this patch:

# dmesg | grep stmmaceth
  stmmaceth f0008000.ethernet: use coherent DMA ops
  stmmaceth f0008000.ethernet: IRQ eth_wake_irq not found
  stmmaceth f0008000.ethernet: IRQ eth_lpi not found
  stmmaceth f0008000.ethernet: PTP uses main clock
  stmmaceth f0008000.ethernet: User ID: 0x10, Synopsys ID: 0x37
  stmmaceth f0008000.ethernet:    DWMAC1000
  stmmaceth f0008000.ethernet: DMA HW capability register supported
  stmmaceth f0008000.ethernet: RX Checksum Offload Engine supported
  stmmaceth f0008000.ethernet: COE Type 2
  stmmaceth f0008000.ethernet: TX Checksum insertion supported
  stmmaceth f0008000.ethernet: Normal descriptors
  stmmaceth f0008000.ethernet: Ring mode enabled
  stmmaceth f0008000.ethernet: Enable RX Mitigation via HW Watchdog Timer
  stmmaceth f0008000.ethernet: device MAC address 26:05:ea:c0:66:16
  stmmaceth f0008000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
  stmmaceth f0008000.ethernet eth0: PHY [stmmac-0:00] driver [Micrel KSZ9031
  Gigabit PHY] (irq=POLL)
  stmmaceth f0008000.ethernet eth0: No Safety Features support found
  stmmaceth f0008000.ethernet eth0: PTP not supported by HW
  stmmaceth f0008000.ethernet eth0: configuring for phy/rgmii-id link mode
  stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off

[1]
arch/arc/boot/dts/hsdk.dts

-- 
Shahab