netdev - RE: [PATCH net-next v3 1/4] vlan: Add MACsec offload operations for VLAN interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Apr 2023 09:43:59 +0000
From:   Emeel Hakim <ehakim@...dia.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>
Subject: RE: [PATCH net-next v3 1/4] vlan: Add MACsec offload operations for
 VLAN interface



> -----Original Message-----
> From: Sabrina Dubroca <sd@...asysnail.net>
> Sent: Wednesday, 5 April 2023 12:38
> To: Emeel Hakim <ehakim@...dia.com>
> Cc: davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com;
> edumazet@...gle.com; netdev@...r.kernel.org; leon@...nel.org
> Subject: Re: [PATCH net-next v3 1/4] vlan: Add MACsec offload operations for
> VLAN interface
> 
> External email: Use caution opening links or attachments
> 
> 
> 2023-03-30, 16:57:12 +0300, Emeel Hakim wrote:
> > +static int vlan_macsec_del_secy(struct macsec_context *ctx) {
> > +     const struct macsec_ops *ops = vlan_get_macsec_ops(ctx);
> > +
> > +     if (!ops || !ops->mdo_del_secy)
> > +             return -EOPNOTSUPP;
> > +
> > +     return ops->mdo_del_secy(ctx);
> > +}
> > +
> > +#undef _BUILD_VLAN_MACSEC_MDO
> 
> FWIW, I didn't have a problem with this particular macro, only
> VLAN_MACSEC_DECLARE_MDO. But if you're going to remove
> _BUILD_VLAN_MACSEC_MDO, you need to remove it completely.

right, I will remove it completely, since I want to prevent doing a return from a macro.

> --
> Sabrina