netdev - RE: [Intel-wired-lan] [PATCH net-next v3 5/8] ice: remove redundant SRIOV code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 09:50:41 +0000
From:   "Romanowski, Rafal" <rafal.romanowski@...el.com>
To:     Simon Horman <simon.horman@...igine.com>,
        "Raczynski, Piotr" <piotr.raczynski@...el.com>
CC:     "Swiatkowski, Michal" <michal.swiatkowski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Saleem, Shiraz" <shiraz.saleem@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next v3 5/8] ice: remove redundant
 SRIOV code

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: niedziela, 26 marca 2023 15:36
> To: Raczynski, Piotr <piotr.raczynski@...el.com>
> Cc: Swiatkowski, Michal <michal.swiatkowski@...el.com>;
> netdev@...r.kernel.org; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; intel-wired-lan@...ts.osuosl.org; Saleem,
> Shiraz <shiraz.saleem@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH net-next v3 5/8] ice: remove
> redundant SRIOV code
> 
> On Thu, Mar 23, 2023 at 01:24:37PM +0100, Piotr Raczynski wrote:
> > Remove redundant code from ice_get_max_valid_res_idx that has no
> effect.
> > ice_pf::irq_tracker is initialized during driver probe, there is no
> > reason to check it again. Also it is not possible for
> > pf::sriov_base_vector to be lower than the tracker length, remove
> WARN_ON that will never happen.
> >
> > Get rid of ice_get_max_valid_res_idx helper function completely since
> > it can never return negative value.
> >
> > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>