lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <857aa6c9-3dcb-d5f7-14bb-6c69c9167b09@linaro.org> Date: Thu, 6 Apr 2023 14:52:56 +0200 From: Konrad Dybcio <konrad.dybcio@...aro.org> To: Rob Herring <robh@...nel.org> Cc: Eric Dumazet <edumazet@...gle.com>, linux-wireless@...r.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, devicetree@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>, Kalle Valo <kvalo@...nel.org>, Andy Gross <agross@...nel.org>, Marijn Suijten <marijn.suijten@...ainline.org>, linux-arm-msm@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, ath10k@...ts.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: net: Convert ATH10K to YAML On 6.04.2023 14:47, Rob Herring wrote: > > On Thu, 06 Apr 2023 13:54:04 +0200, Konrad Dybcio wrote: >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base >> >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. >> >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org> >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 215 ------------ >> .../bindings/net/wireless/qcom,ath10k.yaml | 359 +++++++++++++++++++++ >> 2 files changed, 359 insertions(+), 215 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dtb: wifi@...00000: wifi-firmware: 'wifi-firmware' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dtb: wifi@...00000: wifi-firmware: 'iommus' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > > doc reference errors (make refcheckdocs): > MAINTAINERS: Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230406-topic-ath10k_bindings-v2-1-557f884a65d1@linaro.org Oh, CHECK_DTBS=1 doesn't run dt_binding_check and I didn't run that explicitly before resending.. my bad.. Konrad > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
Powered by blists - more mailing lists