netdev - Re: [PATCH net v2 2/2] net: sfp: avoid EEPROM read of absent SFP module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db9a4f80-2ab1-48ba-84fa-322f9a5da5ec@lunn.ch>
Date:   Thu, 6 Apr 2023 16:06:12 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk,
        hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org,
        system@...rotek.ru
Subject: Re: [PATCH net v2 2/2] net: sfp: avoid EEPROM read of absent SFP
 module

On Thu, Apr 06, 2023 at 04:08:33PM +0300, Ivan Bornyakov wrote:
> If SFP module is not present, it is sensible to fail sfp_module_eeprom()
> and sfp_module_eeprom_by_page() early to avoid excessive I2C transfers
> which are garanteed to fail.
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@...rotek.ru>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew