lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZC7XdVnYWT+o0tLf@corigine.com> Date: Thu, 6 Apr 2023 16:30:13 +0200 From: Simon Horman <simon.horman@...igine.com> To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> Cc: error27@...il.com, kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Marc Kleine-Budde <mkl@...gutronix.de>, Leon Romanovsky <leon@...nel.org>, Kees Cook <keescook@...omium.org>, Rob Herring <robh@...nel.org>, Wolfram Sang <wsa+renesas@...g-engineering.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] niu: Fix missing unwind goto in niu_alloc_channels() On Wed, Apr 05, 2023 at 11:31:18PM -0700, Harshit Mogalapalli wrote: > Smatch reports: drivers/net/ethernet/sun/niu.c:4525 > niu_alloc_channels() warn: missing unwind goto? > > If niu_rbr_fill() fails, then we are directly returning 'err' without > freeing the channels. > > Fix this by changing direct return to a goto 'out_err'. > > Fixes: a3138df9f20e ("[NIU]: Add Sun Neptune ethernet driver.") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> > --- > This is purely based on static analysis. Only compile tested. Reviewed-by: Simon Horman <simon.horman@...igine.com>
Powered by blists - more mailing lists