netdev - Re: [PATCH net-next v4 6/7] bnxt: use new queue try_stop/try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2023 07:36:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com,
        herbert@...dor.apana.org.au, alexander.duyck@...il.com,
        hkallweit1@...il.com, andrew@...n.ch, willemb@...gle.com,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH net-next v4 6/7] bnxt: use new queue try_stop/try_wake
 macros

On Fri, 7 Apr 2023 11:25:23 +0200 Eric Dumazet wrote:
> BTW, we should make sure the @desc argument of netif_txq_try_stop() is
> correctly implemented.
> I often see drivers with either buggy or not efficient implementation.

What do you have in mind?

Should we update the sample code in driver.rst further?
There is outdated sample code there:
https://www.kernel.org/doc/html/next/networking/driver.html
but IDK if people read the documentation :(