netdev - Re: [PATCH] wifi: brcmfmac: add Cypress 43439 SDIO ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2023 16:55:39 +0200
From:   Marek Vasut <marex@...x.de>
To:     Hans de Goede <hdegoede@...hat.com>, linux-wireless@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Arend van Spriel <aspriel@...il.com>,
        Danny van Heumen <danny@...nyvanheumen.nl>,
        Eric Dumazet <edumazet@...gle.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Paul Cercueil <paul@...pouillou.net>,
        SHA-cyfmac-dev-list@...ineon.com,
        Ulf Hansson <ulf.hansson@...aro.org>,
        brcm80211-dev-list.pdl@...adcom.com, linux-mmc@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: add Cypress 43439 SDIO ids

On 4/7/23 15:15, Hans de Goede wrote:
> Hi,

Hi,

> On 4/7/23 03:31, Marek Vasut wrote:
>> Add SDIO ids for use with the muRata 1YN (Cypress CYW43439).
>> The odd thing about this is that the previous 1YN populated
>> on M.2 card for evaluation purposes had BRCM SDIO vendor ID,
>> while the chip populated on real hardware has a Cypress one.
>> The device ID also differs between the two devices. But they
>> are both 43439 otherwise, so add the IDs for both.
>>
>> ```
>> /sys/.../mmc_host/mmc2/mmc2:0001 # cat vendor device
>> 0x04b4
>> 0xbd3d
>> ```
>>
>> Fixes: be376df724aa3 ("wifi: brcmfmac: add 43439 SDIO ids and initialization")
>> Signed-off-by: Marek Vasut <marex@...x.de>
> 
> Thanks, patch looks good to me:

Thanks. I now assembled the old device and got both IDs, so I will add 
them to the commit message and send V2. I also noticed that the old 
device is some ES1.4 chip, while the new one is production silicon:

On-device 1YN (43439), the new one, chip label reads "1YN":
```
/sys/.../mmc_host/mmc2/mmc2:0001 # cat vendor device
0x04b4
0xbd3d
```

EA M.2 evaluation board 1YN (43439), the old one, chip label reads "1YN 
ES1.4":
```
/sys/.../mmc_host/mmc0/mmc0:0001/# cat vendor device
0x02d0
0xa9a6
```