lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f033e357-4277-4ce0-b187-b9032dd26919@lunn.ch> Date: Fri, 7 Apr 2023 17:00:46 +0200 From: Andrew Lunn <andrew@...n.ch> To: Marco Felsch <m.felsch@...gutronix.de> Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Florian Fainelli <f.fainelli@...il.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Richard Cochran <richardcochran@...il.com>, Radu Pirea <radu-nicolae.pirea@....nxp.com>, Shyam Sundar S K <Shyam-sundar.S-k@....com>, Yisen Zhuang <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>, Jassi Brar <jaswinder.singh@...aro.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, Iyappan Subramanian <iyappan@...amperecomputing.com>, Keyur Chudgar <keyur@...amperecomputing.com>, Quan Nguyen <quan@...amperecomputing.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, devicetree@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH 06/12] net: phy: add phy_device_atomic_register helper Lets try again.... There are a number of things i don't like about this patchset. It does too many different things. It pulls workarounds into the core. I don't like the phy_device_config. It would make sense if there were more than 6 arguments to pass to a function, but not for less. I don't like the name phy_device_atomic_register(), but that is bike shedding. There is no really strong argument to change the API. There is no really strong argument to move to fwnode. The problem you are trying to solve is to call phy_device_reset() earlier, before reading the ID registers. Please produce a patchset which is only focused on that. Nothing else. Andrew
Powered by blists - more mailing lists