netdev - Re: [PATCH net-next] ionic: Don't overwrite the cyclecounter bitmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDFs0wYQCaHTLCDq@corigine.com>
Date:   Sat, 8 Apr 2023 15:32:03 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Brett Creeley <brett.creeley@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        drivers@...sando.io, shannon.nelson@....com, allen.hubbe@....com
Subject: Re: [PATCH net-next] ionic: Don't overwrite the cyclecounter bitmask

On Fri, Apr 07, 2023 at 11:45:39AM -0700, Brett Creeley wrote:
> The driver was incorrectly overwriting the cyclecounter bitmask,
> which was truncating it and not aligning to the hardware mask value.
> This isn't causing any issues, but it's wrong. Fix this by not
> constraining the cyclecounter/hardware mask.
> 
> Luckily, this seems to cause no issues, which is why this change
> doesn't have a fixes tag and isn't being sent to net. However, if
> any transformations from time->cycles are needed in the future,
> this change will be needed.
> 
> Suggested-by: Allen Hubbe <allen.hubbe@....com>
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>