netdev - Re: [PATCH v2] wifi: brcmfmac: add Cypress 43439 SDIO ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <509e4308-9164-4131-4b93-75c42568d1e4@denx.de>
Date:   Sat, 8 Apr 2023 18:44:40 +0200
From:   Marek Vasut <marex@...x.de>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     linux-wireless@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Arend van Spriel <aspriel@...il.com>,
        Danny van Heumen <danny@...nyvanheumen.nl>,
        Eric Dumazet <edumazet@...gle.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Paul Cercueil <paul@...pouillou.net>,
        SHA-cyfmac-dev-list@...ineon.com,
        Ulf Hansson <ulf.hansson@...aro.org>,
        brcm80211-dev-list.pdl@...adcom.com, linux-mmc@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] wifi: brcmfmac: add Cypress 43439 SDIO ids

On 4/8/23 17:24, Simon Horman wrote:
> On Fri, Apr 07, 2023 at 10:37:52PM +0200, Marek Vasut wrote:
>> Add SDIO ids for use with the muRata 1YN (Cypress CYW43439).
>> The odd thing about this is that the previous 1YN populated
>> on M.2 card for evaluation purposes had BRCM SDIO vendor ID,
>> while the chip populated on real hardware has a Cypress one.
>> The device ID also differs between the two devices. But they
>> are both 43439 otherwise, so add the IDs for both.
>>
>> On-device 1YN (43439), the new one, chip label reads "1YN":
>> ```
>> /sys/.../mmc_host/mmc2/mmc2:0001 # cat vendor device
>> 0x04b4
>> 0xbd3d
>> ```
>>
>> EA M.2 evaluation board 1YN (43439), the old one, chip label reads "1YN ES1.4":
>> ```
>> /sys/.../mmc_host/mmc0/mmc0:0001/# cat vendor device
>> 0x02d0
>> 0xa9a6
>> ```
>>
>> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>> Fixes: be376df724aa3 ("wifi: brcmfmac: add 43439 SDIO ids and initialization")
>> Signed-off-by: Marek Vasut <marex@...x.de>
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> 
> 
>> ---
>> NOTE: Please drop the Fixes tag if this is considered unjustified
> 
> <2c>
> Feels more like enablement than a fix to me.
> </2c>

I added it because

Documentation/process/stable-kernel-rules.rst

L24  - New device IDs and quirks are also accepted.

So, really, up to the maintainer whether they are fine with it being 
backported to stable releases or not. I don't really mind either way.