netdev - Re: [PATCH net-next v1 2/2] net/ps3_gelic_net: Use napi routines for RX SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9514a013-87fd-4dd9-b266-48f8855ff9b9@lunn.ch>
Date:   Sun, 9 Apr 2023 00:50:13 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Geoff Levand <geoff@...radead.org>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [PATCH net-next v1 2/2] net/ps3_gelic_net: Use napi routines for
 RX SKB

On Sat, Apr 08, 2023 at 10:33:31PM +0000, Geoff Levand wrote:
> Convert the PS3 Gelic network driver's RX SK buffers over to
> use the napi_alloc_frag_align and napi_build_skb routines, and
> then cleanup with the skb_free_frag routine.

Hi Geoff

You might want to take a look at the buffer pool code. The Freescale
FEC driver was converted to it:

commit 95698ff6177b5f1f13f251da60e7348413046ae4
Author: Shenwei Wang <shenwei.wang@....com>
Date:   Fri Sep 30 15:44:27 2022 -0500

    net: fec: using page pool to manage RX buffers
    
    This patch optimizes the RX buffer management by using the page
    pool. The purpose for this change is to prepare for the following
    XDP support. The current driver uses one frame per page for easy
    management.

Although the intention was to make XDP easier to add, the change
increased the performance of the driver in none XDP modes.

	  Andrew