netdev - Re: [PATCH net-next v4 2/5] ice: remove redundant Rx field from rule info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230409103349.GK14869@unreal>
Date:   Sun, 9 Apr 2023 13:33:49 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        wojciech.drewek@...el.com, piotr.raczynski@...el.com,
        pmenzel@...gen.mpg.de, aleksander.lobakin@...el.com,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net-next v4 2/5] ice: remove redundant Rx field from rule
 info

On Fri, Apr 07, 2023 at 06:52:16PM +0200, Michal Swiatkowski wrote:
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
> 
> Setting direction flag doesn't mean that there is a match criteria for
> direction in rule. It is only a information for HW from where switch id
> should be collected (VSI or port). In current implementation of advance
> rule handling, without matching for direction meta data, we can always
> set one the same flag and everything will work the same.
> 
> Ability to match on direction meta data will be added in follow up
> patches.
> 
> Recipe 0, 3 and 9 loaded from package has direction match
> criteria, but they are handled in other function.
> 
> Move ice_adv_rule_info fields to avoid holes.
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_eswitch.c |  1 -
>  drivers/net/ethernet/intel/ice/ice_switch.c  | 22 ++++++++++----------
>  drivers/net/ethernet/intel/ice/ice_switch.h  |  8 +++----
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c  |  5 -----
>  4 files changed, 14 insertions(+), 22 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>