netdev - Re: [PATCH net v2 1/2] iavf: refactor VLAN filter states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230409104046.GO14869@unreal>
Date:   Sun, 9 Apr 2023 13:40:46 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        Ahmed Zaki <ahmed.zaki@...el.com>,
        Rafal Romanowski <rafal.romanowski@...el.com>
Subject: Re: [PATCH net v2 1/2] iavf: refactor VLAN filter states

On Fri, Apr 07, 2023 at 02:07:29PM -0700, Tony Nguyen wrote:
> From: Ahmed Zaki <ahmed.zaki@...el.com>
> 
> The VLAN filter states are currently being saved as individual bits.
> This is error prone as multiple bits might be mistakenly set.
> 
> Fix by replacing the bits with a single state enum. Also, add an
> "ACTIVE" state for filters that are accepted by the PF.
> 
> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf.h        | 15 +++++----
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  8 ++---
>  .../net/ethernet/intel/iavf/iavf_virtchnl.c   | 31 +++++++++----------
>  3 files changed, 28 insertions(+), 26 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>