netdev - Re: [PATCH net] net: Add check for csum_start in skb_partial_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <643447ba5224a_83e69294b6@willemb.c.googlers.com.notmuch>
Date:   Mon, 10 Apr 2023 13:30:34 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>, Lu Wei <luwei32@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        asml.silence@...il.com, imagedong@...cent.com, brouer@...hat.com,
        keescook@...omium.org, jbenc@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: Add check for csum_start in
 skb_partial_csum_set()

Eric Dumazet wrote:
> On Mon, Apr 10, 2023 at 4:22 AM Lu Wei <luwei32@...wei.com> wrote:
> >
> > If an AF_PACKET socket is used to send packets through a L3 mode ipvlan
> > and a vnet header is set via setsockopt() with the option name of
> > PACKET_VNET_HDR, the value of offset will be nagetive in function
> > skb_checksum_help() and trigger the following warning:
> >
> > WARNING: CPU: 3 PID: 2023 at net/core/dev.c:3262
> > skb_checksum_help+0x2dc/0x390
> > ......
> > Call Trace:
> >  <TASK>
> >  ip_do_fragment+0x63d/0xd00
> >  ip_fragment.constprop.0+0xd2/0x150
> >  __ip_finish_output+0x154/0x1e0
> >  ip_finish_output+0x36/0x1b0
> >  ip_output+0x134/0x240
> >  ip_local_out+0xba/0xe0
> >  ipvlan_process_v4_outbound+0x26d/0x2b0
> >  ipvlan_xmit_mode_l3+0x44b/0x480
> >  ipvlan_queue_xmit+0xd6/0x1d0
> >  ipvlan_start_xmit+0x32/0xa0
> >  dev_hard_start_xmit+0xdf/0x3f0
> >  packet_snd+0xa7d/0x1130
> >  packet_sendmsg+0x7b/0xa0
> >  sock_sendmsg+0x14f/0x160
> >  __sys_sendto+0x209/0x2e0
> >  __x64_sys_sendto+0x7d/0x90
> >
> > The root cause is:
> > 1. skb->csum_start is set in packet_snd() according vnet_hdr:
> >    skb->csum_start = skb_headroom(skb) + (u32)start;
> >
> >    'start' is the offset from skb->data, and mac header has been
> >    set at this moment.
> >
> > 2. when this skb arrives ipvlan_process_outbound(), the mac header
> >    is unset and skb_pull is called to expand the skb headroom.
> >
> > 3. In function skb_checksum_help(), the variable offset is calculated
> >    as:
> >       offset = skb->csum_start - skb_headroom(skb);
> >
> >    since skb headroom is expanded in step2, offset is nagetive, and it
> >    is converted to an unsigned integer when compared with skb_headlen
> >    and trigger the warning.
> 
> Not sure why it is negative ? This seems like the real problem...
> 
> csum_start is relative to skb->head, regardless of pull operations.
> 
> whatever set csum_start to a too small value should be tracked and fixed.

Right. The only way I could see it go negative is if something does
the equivalent of pskb_expand_head with positive nhead, and without
calling skb_headers_offset_update.

Perhaps the cause can be found by instrumenting all the above
functions in the trace to report skb_headroom and csum_start.
And also virtio_net_hdr_to_skb.