lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZDRRYCoKxEsNIJ75@corigine.com>
Date:   Mon, 10 Apr 2023 20:11:44 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     "Song, Yoong Siang" <yoong.siang.song@...el.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Stanislav Fomichev <sdf@...gle.com>,
        Alexander Duyck <alexanderduyck@...com>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "xdp-hints@...-project.net" <xdp-hints@...-project.net>
Subject: Re: [PATCH net-next 3/4] net: stmmac: add Rx HWTS metadata to XDP
 receive pkt

On Mon, Apr 10, 2023 at 03:33:48PM +0000, Song, Yoong Siang wrote:
> >On Mon, Apr 10, 2023 at 06:09:38PM +0800, Song Yoong Siang wrote:
> >> Add receive hardware timestamp metadata support via kfunc to XDP
> >> receive packets.
> >>
> >> Signed-off-by: Song Yoong Siang <yoong.siang.song@...el.com>
> >
> >...
> >
> >> @@ -7071,6 +7073,22 @@ void stmmac_fpe_handshake(struct stmmac_priv
> >*priv, bool enable)
> >>  	}
> >>  }
> >>
> >> +static int stmmac_xdp_rx_timestamp(const struct xdp_md *_ctx, u64
> >> +*timestamp) {
> >> +	const struct stmmac_xdp_buff *ctx = (void *)_ctx;
> >> +
> >> +	if (ctx->rx_hwts) {
> >> +		*timestamp = ctx->rx_hwts;
> >> +		return 0;
> >> +	}
> >> +
> >> +	return -ENODATA;
> >> +}
> >> +
> >> +const struct xdp_metadata_ops stmmac_xdp_metadata_ops = {
> >> +	.xmo_rx_timestamp		= stmmac_xdp_rx_timestamp,
> >> +};
> >
> >sparse seems to think this should be static.
> >
> >drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7082:31: warning: symbol
> >'stmmac_xdp_metadata_ops' was not declared. Should it be static?
> Yes, you are right. It should be static. I will add correct it in v2. Thank you.

Thanks

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ