netdev - Re: [net PATCH v2 1/7] octeontx2-af: Secure APR table update with the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 08:25:25 +0000
From:   Sai Krishna Gajula <saikrishnag@...vell.com>
To:     Simon Horman <simon.horman@...igine.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        Linu Cherian <lcherian@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: Re: [net PATCH v2 1/7] octeontx2-af: Secure APR table update with the
 lock

Please see inline,

> -----Original Message-----
> From: Simon Horman <simon.horman@...igine.com>
> Sent: Saturday, April 8, 2023 8:03 PM
> To: Sai Krishna Gajula <saikrishnag@...vell.com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; richardcochran@...il.com;
> Linu Cherian <lcherian@...vell.com>; Jerin Jacob Kollanukkaran
> <jerinj@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
> Subject: Re: [net PATCH v2 1/7] octeontx2-af: Secure APR table update
> with the lock
> 
> On Fri, Apr 07, 2023 at 05:53:38PM +0530, Sai Krishna wrote:
> > From: Geetha sowjanya <gakula@...vell.com>
> >
> > APR table contains the lmtst base address of PF/VFs.
> > These entries are updated by the PF/VF during the device probe. Due to
> > race condition while updating the entries are getting corrupted. Hence
> > secure the APR table update with the lock.
> 
> Hi Sai, Geetha,
> 
> I think it would be useful to describe what races with
> rvu_mbox_handler_lmtst_tbl_setup().

We will rewrite comment message and submit  v3 patch.

Thanks,
Sai
> 
> ...