netdev - Re: [PATCH net-next 1/3] net: docs: update the sample code in driver.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bc0fc8c-a09d-3310-995f-f44e67a9ab54@intel.com>
Date:   Tue, 11 Apr 2023 08:52:03 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>
Subject: Re: [PATCH net-next 1/3] net: docs: update the sample code in
 driver.rst

On 4/10/2023 6:33 PM, Jakub Kicinski wrote:
> The sample code talks about single-queue devices and uses locks.
> Update it to something resembling more modern code.
> Make sure we mention use of READ_ONCE() / WRITE_ONCE().
> 
> Change the comment which talked about consumer on the xmit side.
> AFAIU xmit is the producer and completions are a consumer.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

much better docs, and I'm really happy to see more documentation about
using (READ|WRITE)_ONCE()

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>