netdev - Re: [PATCH net-next 3/3] mlx4: use READ_ONCE/WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4e9f765-87f0-5aa0-3eef-78a3cf60a944@intel.com>
Date:   Tue, 11 Apr 2023 08:52:11 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <tariqt@...dia.com>,
        <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH net-next 3/3] mlx4: use READ_ONCE/WRITE_ONCE for ring
 indexes

On 4/10/2023 6:33 PM, Jakub Kicinski wrote:
> Eric points out that we should make sure that ring index updates
> are wrapped in the appropriate READ_ONCE/WRITE_ONCE macros.
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: tariqt@...dia.com
> CC: linux-rdma@...r.kernel.org

There are a bunch of these issues in the intel directory too, KCSAN was
able to start pointing out some of them but I haven't gotten to fixing
them all. :-(

For this one, looks great!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>