netdev - Re: [RFC PATCH v2 net-next 2/7] net: ethtool: attach an IDR of custom RSS contexts to a netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecaae93a-d41d-4c3d-8e52-2800baa7080d@lunn.ch>
Date:   Tue, 11 Apr 2023 22:36:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     edward.cree@....com
Cc:     linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com,
        Edward Cree <ecree.xilinx@...il.com>, netdev@...r.kernel.org,
        habetsm.xilinx@...il.com, sudheer.mogilappagari@...el.com
Subject: Re: [RFC PATCH v2 net-next 2/7] net: ethtool: attach an IDR of
 custom RSS contexts to a netdevice

>  /**
>   * struct ethtool_netdev_state - per-netdevice state for ethtool features
> + * @rss_ctx_max_id:	maximum (exclusive) supported RSS context ID
> + * @rss_ctx:		IDR storing custom RSS context state
>   * @wol_enabled:	Wake-on-LAN is enabled
>   */
>  struct ethtool_netdev_state {
> +	u32			rss_ctx_max_id;
> +	struct idr		rss_ctx;
>  	unsigned		wol_enabled:1;
>  };

A nitpick. On 64 bit systems, you have a hole between rss_ctx_max_id
and rss_ctx. If you swap those around, and change wol_enabled to also
be a u32 bitfield, the compiler can probably do without the hole.

   Andrew