lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ea711ae7-c730-4347-a148-0602c69c9828@lunn.ch> Date: Tue, 11 Apr 2023 22:40:19 +0200 From: Andrew Lunn <andrew@...n.ch> To: edward.cree@....com Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, Edward Cree <ecree.xilinx@...il.com>, netdev@...r.kernel.org, habetsm.xilinx@...il.com, sudheer.mogilappagari@...el.com Subject: Re: [RFC PATCH v2 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts On Tue, Apr 11, 2023 at 07:26:14PM +0100, edward.cree@....com wrote: > From: Edward Cree <ecree.xilinx@...il.com> > > While this is not needed to serialise the ethtool entry points (which > are all under RTNL), drivers may have cause to asynchronously access > dev->ethtool->rss_ctx; taking dev->ethtool->rss_lock allows them to > do this safely without needing to take the RTNL. What is actually wrong with taking RTNL? KISS is often best, especially for locks. Andrew
Powered by blists - more mailing lists