netdev - Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1e8853a-c510-a898-cb3f-e99f17471269@intel.com>
Date:   Tue, 11 Apr 2023 15:36:15 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Corinna Vinschen <vinschen@...hat.com>, <netdev@...r.kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan



On 4/11/2023 6:00 AM, Corinna Vinschen wrote:
> stmmac_dev_probe doesn't propagate feature flags to VLANs.  So features
> like TX offloading don't correspond with the general features and it's
> not possible to manipulate features via ethtool -K to affect VLANs.
> 
> Signed-off-by: Corinna Vinschen <vinschen@...hat.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index e590b6fc4761..308d4ee12d41 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -7216,6 +7216,8 @@ int stmmac_dvr_probe(struct device *device,
>  	if (priv->dma_cap.rssen && priv->plat->rss_en)
>  		ndev->features |= NETIF_F_RXHASH;
>  
> +	ndev->vlan_features |= ndev->features;
> +
>  	/* MTU range: 46 - hw-specific max */
>  	ndev->min_mtu = ETH_ZLEN - ETH_HLEN;
>  	if (priv->plat->has_xgmac)

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...il.com>