netdev - Re: [PATCH net-next 2/3] bnxt: use READ_ONCE/WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLimmwUtRDemsd=B6ifGe+qrhyKrv2BPZ98ZqKBe02g+uUw@mail.gmail.com>
Date:   Tue, 11 Apr 2023 16:09:57 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next 2/3] bnxt: use READ_ONCE/WRITE_ONCE for ring indexes

On Mon, Apr 10, 2023 at 6:33 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Eric points out that we should make sure that ring index updates
> are wrapped in the appropriate READ_ONCE/WRITE_ONCE macros.
>
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Looks good.  But there is similar logic to update and check TX ring
index in bnxt_xdp.c.  I think we should make the same change there for
consistency.

Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)