netdev - Re: [RFC PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3c23291-2f77-4935-4e1c-a61cbe29241a@suse.de>
Date:   Tue, 11 Apr 2023 08:22:32 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Chris Leech <cleech@...hat.com>, linux-scsi@...r.kernel.org,
        open-iscsi@...glegroups.com, Lee Duncan <leeman.duncan@...il.com>,
        netdev@...r.kernel.org
Subject: Re: [RFC PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace
 aware

On 4/10/23 21:10, Chris Leech wrote:
>> As discussed with Lee: you should tear down sessions related to this
>> namespace from the pernet ->exit callback, otherwise you end up with
>> session which can no longer been reached as the netlink socket is
>> gone.
> 
> These two follow on changes handle removing active sesions when the
> namespace exits. Tested with iscsi_tcp and seems to be working for me.
> 
> Chris Leech (2):
>    iscsi: make session and connection lists per-net
>    iscsi: force destroy sesions when a network namespace exits
> 
>   drivers/scsi/scsi_transport_iscsi.c | 122 ++++++++++++++++++----------
>   1 file changed, 79 insertions(+), 43 deletions(-)
> 
Thanks a lot!
That's precisely what I had been looking for.

But you really shouldn't have mentioned iSCSI offloads; that was too 
large an opening to _not_ comment on :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman