netdev - Re: [PATCH net-next] net/bridge: add drop reasons for bridge forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87e5f12f-ec66-817a-9937-2db0e067d171@blackwall.org>
Date:   Tue, 11 Apr 2023 11:03:54 +0300
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     yang.yang29@....com.cn, davem@...emloft.net
Cc:     edumazet@...gle.com, pabeni@...hat.com, roopa@...dia.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org, kuba@...nel.org,
        zhang.yunkai@....com.cn, jiang.xuexin@....com.cn
Subject: Re: [PATCH net-next] net/bridge: add drop reasons for bridge
 forwarding

On 06/04/2023 14:30, yang.yang29@....com.cn wrote:
> From: xu xin <xu.xin16@....com.cn>
> 
> This creates six drop reasons as follows, which will help users know the
> specific reason why bridge drops the packets when forwarding.
> 
> 1) SKB_DROP_REASON_BRIDGE_FWD_NO_BACKUP_PORT: failed to get a backup
>    port link when the destination port is down.
> 
> 2) SKB_DROP_REASON_BRIDGE_FWD_SAME_PORT: destination port is the same
>    with originating port when forwarding by a bridge.
> 
> 3) SKB_DROP_REASON_BRIDGE_NON_FORWARDING_STATE: the bridge's state is
>    not forwarding.
> 
> 4) SKB_DROP_REASON_BRIDGE_NOT_ALLOWED_EGRESS: the packet is not allowed
>    to go out through the port due to vlan filtering.
> 
> 5) SKB_DROP_REASON_BRIDGE_SWDEV_NOT_ALLOWED_EGRESS: the packet is not
>    allowed to go out through the port which is offloaded by a hardware
>    switchdev, checked by nbp_switchdev_allowed_egress().
> 
> 6) SKB_DROP_REASON_BRIDGE_BOTH_PORT_ISOLATED: both source port and dest
>    port are in BR_ISOLATED state when bridge forwarding.
> 
> Signed-off-by: xu xin <xu.xin16@....com.cn>
> Reviewed-by: Zhang Yunkai <zhang.yunkai@....com.cn>
> Reviewed-by: Yang Yang <yang.yang19@....com.cn>
> Cc: Xuexin Jiang <jiang.xuexin@....com.cn>
> ---
>  include/net/dropreason.h | 33 ++++++++++++++++++++++++++++++++
>  net/bridge/br_forward.c  | 49 +++++++++++++++++++++++++++++++++++++-----------
>  2 files changed, 71 insertions(+), 11 deletions(-)
> 

In addition to Jakub's comments, next time please CC bridge maintainers.
I just noticed this patch now.

Thanks,
 Nik