netdev - Re: [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168129381469.14673.15764454080204541798.kvalo@kernel.org>
Date:   Wed, 12 Apr 2023 10:03:36 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Cai Huoqing <cai.huoqing@...ux.dev>
Cc:     cai.huoqing@...ux.dev, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Yan-Hsuan Chuang <tony0620emma@...il.com>,
        Ping-Ke Shih <pkshih@...ltek.com>, ath10k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ath11k@...ts.infradead.org,
        ath12k@...ts.infradead.org
Subject: Re: [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master

Cai Huoqing <cai.huoqing@...ux.dev> wrote:

> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
>         u16 pci_command;
> 
>         pci_read_config_word(dev, PCI_COMMAND, &pci_command);
>         if (pci_command & PCI_COMMAND_MASTER) {
>                 pci_command &= ~PCI_COMMAND_MASTER;
>                 pci_write_config_word(dev, PCI_COMMAND, pci_command);
>         }
> 
>         pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@...ux.dev>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

3 patches applied to ath-next branch of ath.git, thanks.

f812e2a9f85d wifi: ath11k: Remove redundant pci_clear_master
76008fc13b09 wifi: ath10k: Remove redundant pci_clear_master
b9235aef8492 wifi: ath12k: Remove redundant pci_clear_master

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-1-cai.huoqing@linux.dev/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches