lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <153a5ed0-5f4f-4879-2677-e5bce5453634@linaro.org> Date: Wed, 12 Apr 2023 18:39:31 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Arınç ÜNAL <arinc.unal@...nc9.com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Daniel Golle <daniel@...rotopia.org>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Sean Wang <sean.wang@...iatek.com> Cc: erkin.bozoglu@...ont.com, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH 3/7] dt-bindings: net: dsa: mediatek,mt7530: add port bindings for MT7988 On 07/04/2023 11:46, Arınç ÜNAL wrote: > On 7.04.2023 12:07, Krzysztof Kozlowski wrote: >> On 06/04/2023 21:18, Arınç ÜNAL wrote: >>> On 6.04.2023 22:07, Krzysztof Kozlowski wrote: >>>> On 06/04/2023 10:01, arinc9.unal@...il.com wrote: >>>>> From: Arınç ÜNAL <arinc.unal@...nc9.com> >>>>> >>>>> The switch on MT7988 has got only port 6 as a CPU port. The only phy-mode >>>>> to be used is internal. Add this. >>>>> >>>>> Some bindings are incorrect for this switch now, so move them to more >>>>> specific places. >>>>> >>>>> Address the incorrect information of which ports can be used as a user >>>>> port. Any port can be used as a user port. >>>>> >>>>> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com> >>>>> --- >>>>> .../bindings/net/dsa/mediatek,mt7530.yaml | 63 ++++++++++++++----- >>>>> 1 file changed, 46 insertions(+), 17 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>>>> index 7045a98d9593..605888ce2bc6 100644 >>>>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>>>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>>>> @@ -160,22 +160,6 @@ patternProperties: >>>>> "^(ethernet-)?port@[0-9]+$": >>>>> type: object >>>>> >>>>> - properties: >>>>> - reg: >>>>> - description: >>>>> - Port address described must be 5 or 6 for CPU port and from 0 to 5 >>>>> - for user ports. >>>>> - >>>>> - allOf: >>>>> - - if: >>>>> - required: [ ethernet ] >>>>> - then: >>>>> - properties: >>>>> - reg: >>>>> - enum: >>>>> - - 5 >>>>> - - 6 >>>>> - >>>> >>>> I have doubts that the binding is still maintainable/reviewable. First, >>>> why do you need all above patterns after removal of entire contents? >>> >>> The 'type: object' item is still globally used. I'd have to define that >>> on each definitions, I suppose? >> >> Doesn't it come from dsa.yaml/dsa-port.yaml schema? > > It comes from dsa.yaml#/$defs/ethernet-ports which this schema already > refers to. I'll remove the patterns above. > > Though 'type: object' is not there for "^(ethernet-)?port@[0-9]+$". I > think I should add it there as the dsa-port.yaml schema defines the > properties of the DSA switch port object. It has ref, which is enough. > So the value matching the > "^(ethernet-)?port@[0-9]+$" regular expression is expected to be an > object conforming to the structure defined in dsa-port.yaml. > > Does that make sense? Hm, no, sorry, I still do not see what exactly is missing from dsa.yaml/port that you need to define here. Best regards, Krzysztof
Powered by blists - more mailing lists