lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230412170437.26nwldbxydm7lgxm@skbuf> Date: Wed, 12 Apr 2023 20:04:37 +0300 From: Vladimir Oltean <vladimir.oltean@....com> To: Ido Schimmel <idosch@...dia.com> Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Hans J. Schultz" <netdev@...io-technology.com>, Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>, Ivan Vecera <ivecera@...hat.com>, Jiri Pirko <jiri@...nulli.us>, Arkadi Sharshevsky <arkadis@...lanox.com>, Ido Schimmel <idosch@...lanox.com>, bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic" On Wed, Apr 12, 2023 at 07:49:17PM +0300, Ido Schimmel wrote: > On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote: > > I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being > > notified from switchdev. > > > > Unless you have any objection, I won't send v2 like this: > > > > if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) && > > !test_bit(BR_FDB_STATIC, &fdb->flags) && > > !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags)) > > return; > > > > but like this: > > > > /* Entries with just the BR_FDB_ADDED_BY_USER flag set were created > > * using 'bridge fdb add ... master dynamic' > > */ > > if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER)) > > return; > > LGTM. Please copy me on v2 and I will run it through regression. Will > try to report results before tomorrow's PR. Sorry, I won't send the v2 early; I need to think more about this and I don't want to rush things. It's likely that the zero-day bug fix will miss this week's PR.
Powered by blists - more mailing lists