netdev - Re: [PATCH bpf-next v5 0/4] xsk: Support UMEM chunk_size > PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Apr 2023 20:51:59 +0200
From:   Kal Cutter Conley <kal.conley@...tris.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     Magnus Karlsson <magnus.karlsson@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        bpf@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
        Gal Pressman <gal@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH bpf-next v5 0/4] xsk: Support UMEM chunk_size > PAGE_SIZE

> Thank you so much Kal for implementing this feature. After you have
> fixed the three small things I had for patch #2, you have my ack for
> the whole set below. Please add it.
>
> For the whole set:
> Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>
>
> It would be great if you have the time and desire to also take this to
> zero-copy mode. I have had multiple AF_XDP users mailing me privately
> that such a feature would be very useful for them. For some of them it
> was even a requirement to be able to get down to the latencies they
> were aiming for.

Yes. We need this to work with zero-copy so next I will look into
implementing this for the mlx5 driver since it has to work for us on
Mellanox adapters.

Roping in the Mellanox engineers in case they want to add something :-)