lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <90ee1533-008c-f90e-5f23-f3c42cda85a7@intel.com> Date: Wed, 12 Apr 2023 14:18:56 -0700 From: Jacob Keller <jacob.e.keller@...el.com> To: Vladimir Oltean <vladimir.oltean@....com>, <netdev@...r.kernel.org> CC: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Claudiu Manoil" <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, <UNGLinuxDriver@...rochip.com>, Colin Foster <colin.foster@...advantage.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next 5/8] net: dsa: felix: remove confusing/incorrect comment from felix_setup() On 4/12/2023 5:47 AM, Vladimir Oltean wrote: > That comment was written prior to knowing that what I was actually > seeing was a manifestation of the bug fixed in commit b4024c9e5c57 > ("felix: Fix initialization of ioremap resources"). > > There isn't any particular reason now why the hardware initialization is > done in felix_setup(), so just delete that comment to avoid spreading > misinformation. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> > --- > drivers/net/dsa/ocelot/felix.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c > index 6dcebcfd71e7..80861ac090ae 100644 > --- a/drivers/net/dsa/ocelot/felix.c > +++ b/drivers/net/dsa/ocelot/felix.c > @@ -1550,11 +1550,6 @@ static int felix_connect_tag_protocol(struct dsa_switch *ds, > } > } > > -/* Hardware initialization done here so that we can allocate structures with > - * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing > - * us to allocate structures twice (leak memory) and map PCI memory twice > - * (which will not work). > - */ > static int felix_setup(struct dsa_switch *ds) > { > struct ocelot *ocelot = ds->priv; Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
Powered by blists - more mailing lists