netdev - RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB6289BB9BA4BC0B398F2989108F9B9@AM0PR04MB6289.eurprd04.prod.outlook.com>
Date:   Wed, 12 Apr 2023 21:30:05 +0000
From:   Leo Li <leoyang.li@....com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Stuart Yoder <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Roy Pledge <roy.pledge@....com>,
        Horia Geanta <horia.geanta@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Gaurav Jain <gaurav.jain@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Vinod Koul <vkoul@...nel.org>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, "Y.B. Lu" <yangbo.lu@....com>,
        "Diana Madalina Craciun (OSS)" <diana.craciun@....nxp.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Richard Cochran <richardcochran@...il.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void



> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Sent: Wednesday, April 12, 2023 12:11 PM
> To: Stuart Yoder <stuyoder@...il.com>; Laurentiu Tudor
> <laurentiu.tudor@....com>; Roy Pledge <roy.pledge@....com>; Leo Li
> <leoyang.li@....com>; Horia Geanta <horia.geanta@....com>; Pankaj
> Gupta <pankaj.gupta@....com>; Gaurav Jain <gaurav.jain@....com>;
> Herbert Xu <herbert@...dor.apana.org.au>; David S. Miller
> <davem@...emloft.net>; Vinod Koul <vkoul@...nel.org>; Ioana Ciornei
> <ioana.ciornei@....com>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Y.B. Lu
> <yangbo.lu@....com>; Diana Madalina Craciun (OSS)
> <diana.craciun@....nxp.com>; Alex Williamson
> <alex.williamson@...hat.com>; Richard Cochran
> <richardcochran@...il.com>
> Cc: kvm@...r.kernel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-crypto@...r.kernel.org;
> kernel@...gutronix.de; dmaengine@...r.kernel.org; linuxppc-
> dev@...ts.ozlabs.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void
> 
> Hello,
> 
> On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > many bus remove functions return an integer which is a historic
> > misdesign that makes driver authors assume that there is some kind of
> > error handling in the upper layers. This is wrong however and
> > returning and error code only yields an error message.
> >
> > This series improves the fsl-mc bus by changing the remove callback to
> > return no value instead. As a preparation all drivers are changed to
> > return zero before so that they don't trigger the error message.
> 
> Who is supposed to pick up this patch series (or point out a good reason for
> not taking it)?

Previously Greg KH picked up MC bus patches.

If no one is picking up them this time, I probably can take it through the fsl soc tree.

Regards,
Leo