lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5cb4df2b-e20b-06f8-c2f6-5db52805d672@intel.com> Date: Wed, 12 Apr 2023 14:38:55 -0700 From: "Tantilov, Emil S" <emil.s.tantilov@...el.com> To: Simon Horman <simon.horman@...igine.com>, Pavan Kumar Linga <pavan.kumar.linga@...el.com> CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, <joshua.a.hay@...el.com>, <sridhar.samudrala@...el.com>, <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>, <willemb@...gle.com>, <decot@...gle.com>, <pabeni@...hat.com>, <kuba@...nel.org>, <edumazet@...gle.com>, <davem@...emloft.net>, Alan Brady <alan.brady@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, Phani Burra <phani.r.burra@...el.com> Subject: Re: [PATCH net-next v2 01/15] virtchnl: add virtchnl version 2 ops On 4/11/2023 1:51 AM, Simon Horman wrote: > On Mon, Apr 10, 2023 at 06:13:40PM -0700, Pavan Kumar Linga wrote: >> Virtchnl version 1 is an interface used by the current generation of >> foundational NICs to negotiate the capabilities and configure the >> HW resources such as queues, vectors, RSS LUT, etc between the PF >> and VF drivers. It is not extensible to enable new features supported >> in the next generation of NICs/IPUs and to negotiate descriptor types, >> packet types and register offsets. >> >> To overcome the limitations of the existing interface, introduce >> the virtchnl version 2 and add the necessary opcodes, structures, >> definitions, and descriptor formats. The driver also learns the >> data queue and other register offsets to use instead of hardcoding >> them. The advantage of this approach is that it gives the flexibility >> to modify the register offsets if needed, restrict the use of >> certain descriptor types and negotiate the supported packet types. >> >> Co-developed-by: Alan Brady <alan.brady@...el.com> >> Signed-off-by: Alan Brady <alan.brady@...el.com> >> Co-developed-by: Joshua Hay <joshua.a.hay@...el.com> >> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com> >> Co-developed-by: Madhu Chittim <madhu.chittim@...el.com> >> Signed-off-by: Madhu Chittim <madhu.chittim@...el.com> >> Co-developed-by: Phani Burra <phani.r.burra@...el.com> >> Signed-off-by: Phani Burra <phani.r.burra@...el.com> >> Co-developed-by: Sridhar Samudrala <sridhar.samudrala@...el.com> >> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com> >> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com> >> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com> >> Reviewed-by: Willem de Bruijn <willemb@...gle.com> >> --- >> drivers/net/ethernet/intel/idpf/virtchnl2.h | 1201 +++++++++++++++++ >> .../ethernet/intel/idpf/virtchnl2_lan_desc.h | 666 +++++++++ >> 2 files changed, 1867 insertions(+) >> create mode 100644 drivers/net/ethernet/intel/idpf/virtchnl2.h >> create mode 100644 drivers/net/ethernet/intel/idpf/virtchnl2_lan_desc.h >> >> diff --git a/drivers/net/ethernet/intel/idpf/virtchnl2.h b/drivers/net/ethernet/intel/idpf/virtchnl2.h > > ... > >> +/** >> + * This macro is used to generate compilation errors if a structure >> + * is not exactly the correct length. >> + */ > > Hi Pavan, > > ./scripts/kernel-doc -none drivers/net/ethernet/intel/idpf/virtchnl2.h > reports that the comment above starts with '/**' but is not a kernel-doc > comment. Which seems to be correct. It also flags many other similar issues. > > Please consider running kernel-doc and resolving the issues it flags. Will address in v3. Thanks for the tip! Emil
Powered by blists - more mailing lists