netdev - Re: [PATCH net-next v2 3/3] mlx4: use READ_ONCE/WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d13ca06-3183-8511-62fd-ae267a9b4699@gmail.com>
Date:   Wed, 12 Apr 2023 09:07:13 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        tariqt@...dia.com, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/3] mlx4: use READ_ONCE/WRITE_ONCE for ring
 indexes



On 12/04/2023 4:50, Jakub Kicinski wrote:
> Eric points out that we should make sure that ring index updates
> are wrapped in the appropriate READ_ONCE/WRITE_ONCE macros.
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: tariqt@...dia.com
> CC: linux-rdma@...r.kernel.org
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>
Thanks!