lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <781d4288-f7c6-f3e6-a132-77bff41880c7@arinc9.com> Date: Wed, 12 Apr 2023 09:35:15 +0300 From: Arınç ÜNAL <arinc.unal@...nc9.com> To: Vladimir Oltean <olteanv@...il.com> Cc: Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Daniel Golle <daniel@...rotopia.org>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Russell King <linux@...linux.org.uk>, Richard van Schagen <richard@...terhints.com>, Richard van Schagen <vschagen@...com>, Frank Wunderlich <frank-w@...lic-files.de>, erkin.bozoglu@...ont.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [RFC PATCH v2 net-next 06/14] net: dsa: mt7530: do not set CPU port interfaces to PHY_INTERFACE_MODE_NA On 11.04.2023 17:54, Vladimir Oltean wrote: > On Fri, Apr 07, 2023 at 04:46:18PM +0300, arinc9.unal@...il.com wrote: >> From: Arınç ÜNAL <arinc.unal@...nc9.com> >> >> There is no need to set priv->p5_interface and priv->p6_interface to >> PHY_INTERFACE_MODE_NA on mt7530_setup() and mt7531_setup(). >> >> As Vladimir explained, in include/linux/phy.h we have: >> >> Therefore, do not put 0 into a variable containing 0. > > The explanation is unnecessarily long. I only provided it to make sure > you understand. I don't see a problem with a bit of verbosity on the patch log. It should make the reader understand the code path better. Arınç
Powered by blists - more mailing lists