netdev - Re: [PATCH] skbuff: Fix a race between coalescing and releasing SKBs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKhg4tK74HRuZ8MgAG1t6oQ+CV4o6y3QLvuYOkWUPCZMHjUyxw@mail.gmail.com>
Date:   Wed, 12 Apr 2023 15:27:13 +0800
From:   Liang Chen <liangchen.linux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     ilias.apalodimas@...aro.org, hawk@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] skbuff: Fix a race between coalescing and releasing SKBs

Sure. I have addressed it and submitted the updated patch for your
review as v3. Thank you for pointing it out.

Thanks,
Liang

On Tue, Apr 11, 2023 at 8:26 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue,  4 Apr 2023 15:47:33 +0800 Liang Chen wrote:
> > -     if (to->pp_recycle != (from->pp_recycle && !skb_cloned(from)))
> > +     if ((to->pp_recycle != from->pp_recycle)
> > +             || (from->pp_recycle && skb_cloned(from)))
> >               return false;
>
> It should be formatted like this:
>
>         if (to->pp_recycle != from->pp_recycle ||
>             (from->pp_recycle && skb_cloned(from)))