lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230412080343.GF33314@black.fi.intel.com> Date: Wed, 12 Apr 2023 11:03:43 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: Simon Horman <simon.horman@...igine.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Michael Jamet <michael.jamet@...el.com>, Yehezkel Bernat <YehezkelShB@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH v2 2/3] net: thunderbolt: Fix sparse warnings in tbnet_xmit_csum_and_map() On Tue, Apr 11, 2023 at 02:37:58PM +0200, Simon Horman wrote: > On Tue, Apr 11, 2023 at 02:58:21PM +0300, Andy Shevchenko wrote: > > On Tue, Apr 11, 2023 at 01:50:16PM +0200, Simon Horman wrote: > > > On Tue, Apr 11, 2023 at 12:10:48PM +0300, Mika Westerberg wrote: > > > > Fixes the following warning when the driver is built with sparse checks > > > > enabled: > > > > > > > > main.c:993:23: warning: incorrect type in initializer (different base types) > > > > main.c:993:23: expected restricted __wsum [usertype] wsum > > > > main.c:993:23: got restricted __be32 [usertype] > > > > > > > > No functional changes intended. > > > > > > This seems nice. > > > > > > After you posted v1 I was wondering if, as a follow-up, it would be worth > > > creating a helper for this, say cpu_to_wsum(), as I think this pattern > > > occurs a few times. I'm thinking of a trivial wrapper around cpu_to_be32(). > > > > But it looks like it makes sense to have a standalone series for that matter. > > I.o.w. it doesn't belong to Thunderbolt (only). > > Yes, agreed. > > I was more asking if it is a good idea than for any changes to this patchset. I think it is a good idea :) I'll add this to my todo list and will do at some point if nobody else have already done it.
Powered by blists - more mailing lists