lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20230412081929.173220-7-mschmidt@redhat.com> Date: Wed, 12 Apr 2023 10:19:29 +0200 From: Michal Schmidt <mschmidt@...hat.com> To: intel-wired-lan@...ts.osuosl.org Cc: netdev@...r.kernel.org, Jesse Brandeburg <jesse.brandeburg@...el.com>, Karol Kolacinski <karol.kolacinski@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Simon Horman <simon.horman@...igine.com>, Michal Michalik <michal.michalik@...el.com>, Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, Petr Oros <poros@...hat.com>, Andrew Lunn <andrew@...n.ch> Subject: [PATCH net-next v2 6/6] ice: sleep, don't busy-wait, in the SQ send retry loop 10 ms is a lot of time to spend busy-waiting. Sleeping is clearly allowed here, because we have just returned from ice_sq_send_cmd(), which takes a mutex. On kernels with HZ=100, this msleep may be twice as long, but I don't think it matters. I did not actually observe any retries happening here. Signed-off-by: Michal Schmidt <mschmidt@...hat.com> --- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index c6200564304e..0157f6e98d3e 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -1643,7 +1643,7 @@ ice_sq_send_cmd_retry(struct ice_hw *hw, struct ice_ctl_q_info *cq, memcpy(desc, &desc_cpy, sizeof(desc_cpy)); - mdelay(ICE_SQ_SEND_DELAY_TIME_MS); + msleep(ICE_SQ_SEND_DELAY_TIME_MS); } while (++idx < ICE_SQ_SEND_MAX_EXECUTE); -- 2.39.2
Powered by blists - more mailing lists