netdev - Re: [PATCH v9 net-next 02/14] pds_core: add devcmd device interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230413080858.26c2f3eb@kernel.org>
Date:   Thu, 13 Apr 2023 08:08:58 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Shannon Nelson <shannon.nelson@....com>, brett.creeley@....com,
        davem@...emloft.net, netdev@...r.kernel.org, drivers@...sando.io,
        jiri@...nulli.us
Subject: Re: [PATCH v9 net-next 02/14] pds_core: add devcmd device
 interfaces

On Thu, 13 Apr 2023 11:33:25 +0300 Leon Romanovsky wrote:
> > > This is only relevant here, everything else is not applicable.
> > >   
> > > > +     PDS_DRIVER_WIN     = 2,
> > > > +     PDS_DRIVER_DPDK    = 3,
> > > > +     PDS_DRIVER_FREEBSD = 4,
> > > > +     PDS_DRIVER_IPXE    = 5,
> > > > +     PDS_DRIVER_ESXI    = 6,
> > > > +};  
> > 
> > Yes, they are rather pointless for the Linux kernel, but it is part of
> > documenting the device interface.  
> 
> It is not used in upstream kernel.

If Shannon prefers to keep the full enum, I think that's fine.
Declaring the full interface is often the only way a user can
try to figure out how the API works, as most vendors don't publish
their APIs.